Skip to content

Conversation

@JosephSemrai
Copy link

@JosephSemrai JosephSemrai commented Dec 27, 2019

Description

Added GitHub and LinkedIn social media buttons to various points in the application (main view and login view). Upon clicking these buttons, the user is redirected using ng-href.

Motivation and Context

Allows Bassa users to view social media and contact points from various points in the application. Also serves as an attribution point.

How Has This Been Tested?

Tested by running the application and the tests script.

Screenshots (In case of UI changes):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JosephSemrai JosephSemrai changed the base branch from master to develop December 27, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant