Introduce Dynamic constants, Theming option#177
Open
ajaman190 wants to merge 6 commits intoscorelab:masterfrom
Open
Introduce Dynamic constants, Theming option#177ajaman190 wants to merge 6 commits intoscorelab:masterfrom
ajaman190 wants to merge 6 commits intoscorelab:masterfrom
Conversation
Contributor
Author
|
@shehand kindly review this pull request. I am looking forward for feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce dynamic constants, theming option #172
Summary:
This pull request introduces a new feature of theming and making the app more dynamic to different screens.
Issues:
Issue resolved Checklists:
Recording:
I have tested these changes thoroughly to ensure that they work as expected.
Project.1.mp4
Ignore the first three commit they belong to the last pr # 176 (login and signup).
@shehand Please let me know if there are any issues or concerns with this pull request. I am happy to address any feedback or suggestions that you may have.