New ask geo api#1
Open
thrillcall wants to merge 3 commits into
Open
Conversation
The old AskGeo API is being turned off. This is a breaking change as the results from the new API have a slightly different structure than before. See : http://askgeo.com/new_version
|
+1. we've been using @thrillcall 's version after the switch, without issue. |
|
+1 we've been using it as well. Thanks @thrillcall for taking care of this. |
Author
|
Hi scottwb, Any chance we can get this merged into upstream and a new gem released? Thx. |
Owner
|
Yes. Sorry, I meant to do this earlier in the year, but it got lost in the perpetual pile of stuff to do. I will take a look at this weekend. Thanks for the reminder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the gem to include the changes required by AskGeo as they are now deprecating their old API which will cease to function next month. I have also updated the gem and specs to work with the slightly different API results that they return now.
Since this is a breaking change it should likely be in a major version release of the Gem. However, you may choose to force people to switch since the old API will actually be turned off whether they update the gem or not.
See : http://askgeo.com/new_version
From their email :