Add support for default favicon verification disabling#33
Conversation
Fixed issue with dimensions(tag) not working for some websites
Change: test corrected and minimized
…/favicon.ico file, to have similar behavior to tag-based favicon results. * Fixed flaky test.
|
@scottwernervt any thoughts about merging this in? |
scottwernervt
left a comment
scottwernervt
left a comment
There was a problem hiding this comment.
I do not want to break Python 2 support even though it is deprecated (a lot of people still use it). I was thinking this week that maybe we should refactor the package and make each parser method public:
def get(url, *args, **request_kwargs)uses parses belowdef parse_default_icon(url, **request_kwargs)def parse_html_icons(url, html)
This would handle your case of parsing icons with your own html content instead of relying on bs4. Once you remove verify_default_icon arg, I will merge your PR, refactor it to above, and make a new release.
| the `url`. | ||
| :type html_override: str or None | ||
|
|
||
| :param verify_default_icon: Whether to verify the existence of the default |
There was a problem hiding this comment.
Please remove verify_default_icon arg and logic. I do not understand why a user would want to return a found icon http://www.mysite.com/favicon.ico that doesn't actually exist?
|
Why don't we increase the major version, so it can include breaking changes? We can version it v1.0.0. Python 2 has reached its end of life. There is no point in supporting it in new versions of this project. What do you think? |
2 participants
to tag-based favicon results.
Includes PR #32 as well, as it wasn't merged yet.