Add timeout parameter to requests calls because they can hang forever…#37
Open
Xangis wants to merge 1 commit into
Open
Add timeout parameter to requests calls because they can hang forever…#37Xangis wants to merge 1 commit into
Xangis wants to merge 1 commit into
Conversation
… if the connection does not close properly.
Owner
|
@Xangis Thanks for the PR but the timeout value should be left up to the user of this package. We provide an example in the README for setting
Maybe instead we can add a note to the README to set it if you are experiencing hangs. |
Author
|
Sure, a note would be good. Requests recommends never calling it without a timeout value because it can hang infinitely, so I figured having some sort of default, even if it's ridiculously long, would prevent nasty surprises. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timeout parameter to requests calls because they can hang forever if the connection does not close properly.
I've been using this modified version for my own icon harvesting script and the addition of the timeout parameter prevents hangs.
You may want to adjust the timeout, but 20 seconds has worked well enough for me.