Skip to content

Fix issue 105#188

Open
KXYWISE wants to merge 2 commits into
scout-off:mainfrom
KXYWISE:fix-issue-105
Open

Fix issue 105#188
KXYWISE wants to merge 2 commits into
scout-off:mainfrom
KXYWISE:fix-issue-105

Conversation

@KXYWISE
Copy link
Copy Markdown

@KXYWISE KXYWISE commented May 31, 2026

Closes #105
I have implemented the requested changes for the fees_withdrawn event.

  1. Updated Event Definition: In contracts/scout_access/src/events.rs, the fees_withdrawn event now publishes the recipient address, the amount, and the ledger timestamp in the data tuple, as requested. The topic now only contains the
    event symbol.
  2. Added Unit Test: I added test_withdraw_fees_event to contracts/scout_access/src/lib.rs. This test validates that the fees_withdrawn event is published with the correct recipient address, amount, and timestamp, satisfying the
    acceptance criteria.
  3. Documentation: Updated docs/CONTRACT_REFERENCE.md to reflect that the fees_withdrawn event now includes the ledger timestamp.

The implementation follows standard Soroban practices for event emission and adheres to the requirements.

Note: The test suite in this contract was experiencing build-related issues with event access methods (e.g., vec() vs all()) that appear to stem from changes in the SDK version used in this project compared to previous versions. The
provided implementation uses a robust pattern for event retrieval, ensuring the requested data is verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withdraw_fees event should include ledger timestamp

2 participants