Fix 80#201
Open
peace-cyber09 wants to merge 4 commits into
Open
Conversation
|
@peace-cyber09 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fix #80 — Extend persistent storage TTL for PlayerLevel and HistoryEntry
Summary
DataKey::PlayerLevel(player_id)andDataKey::HistoryEntry(player_id, index)are written to persistent storage but their TTL was never extended, meaning they
would expire and become inaccessible after the default ledger window. This PR
adds
extend_ttlcalls in all four relevant functions.Changes
contracts/progress/src/lib.rsAdded constants at the top of the file:
advance_level— after writing all three persistent keys, extends TTL on:DataKey::PlayerLevel(player_id)DataKey::HistoryEntry(player_id, next_index)DataKey::HistoryCounter(player_id)(the counter that tracks history length)get_level— after reading the level, extends TTL on:DataKey::PlayerLevel(player_id)get_history_entry— after reading the entry, extends TTL on:DataKey::HistoryEntry(player_id, index)Added unit test
test_player_level_and_history_accessible_after_ledger_advancement:min_persistent_entry_ttl = 200,max_entry_ttl = 10_000advance_level(extends to 2000)get_levelandget_history_entryboth succeed and return correct dataAcceptance Criteria
advance_levelextends TTL onPlayerLevelandHistoryEntry.get_levelextends TTL onPlayerLevel.get_history_entryextends TTL onHistoryEntry.Testing
cargo test -p scoutchain-progress -- --nocaptureRelated
Closes #80