fix(3433): virtual job icon sizing on graph redraw#1563
Open
Conversation
y-oksaku
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When a virtual job was initially rendered with the virtual icon and later updated to a non-virtual status such as
BLOCKED, the workflow graph could keep the previous oversized icon styling after redraw.This happened because the redraw path updated the icon glyph, but the size and position attributes were not being reapplied to the actual
textelement that renders the icon. As a result, the icon could stay visually enlarged even after the status changed.Objective
This PR fixes virtual job icon rendering during graph redraw by updating the icon
textelement directly so that its size and position stay in sync with the current status.References
screwdriver-cd/screwdriver#3433
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.