fix(3433): highlight the selected job when navigating from build details to event views#1564
Open
fix(3433): highlight the selected job when navigating from build details to event views#1564
Conversation
…ils to event views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When navigating from the build details page to an event page through the job link in the build banner, the target job was no longer highlighted in the workflow view. In some cases, the v2 flow also opened the latest event instead of the event associated with the current build, and adding a
jobIdquery parameter broke the selected event card styling.Objective
This PR restores the expected behavior when opening an event page from build details. It ensures the UI navigates to the event associated with the current build, passes the selected job through the transition, and highlights that job in both v1 and v2 workflow views by scrolling to it and rendering its name in red.
It also keeps the selected event card highlighted when
jobIdis present in the URL.↓
References
screwdriver-cd/screwdriver#3433
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.