Skip to content

Comments

Use new downloaded db#550

Open
catreedle wants to merge 16 commits intoscribe-org:mainfrom
catreedle:read-new-db
Open

Use new downloaded db#550
catreedle wants to merge 16 commits intoscribe-org:mainfrom
catreedle:read-new-db

Conversation

@catreedle
Copy link
Collaborator

Contributor checklist


Description

This PR removes the old {language}LanguageData.sqlite files and changes Scribe functionality to use the new downloaded sqlite files.

  • New file: SQLiteExtension.kt a helper file to check if a table or column exists in a database. These helper functions will be called before query attempt to handle error gracefully.
  • Removes built in language data in main/assets/data.
  • Changes DatabaseFileManager.kt to read from the new downloaded db.
  • Changes in AutoSuggestionDataManager.kt, AutocompletionDataManager.kt, ConjugateDataManager.kt, EmojiDataManager.kt, PrepositionDataManager.kt to confirm that table and column exists before query attempt.
  • Minor changes in DataDownloadViewModel.kt and DynamicDbHelper.kt to change download db file name.

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants