Skip to content

test: fix Skill Validation admission launch and import scan - #131

Merged
scrimshawlife-ctrl merged 3 commits into
mainfrom
cursor/ci-fix-admission-import-41af
Sep 27, 2026
Merged

scrimshawlife-ctrl merged 3 commits into
mainfrom
cursor/ci-fix-admission-import-41af

Conversation

@scrimshawlife-ctrl

Copy link
Copy Markdown
Owner

Separate CI fix for two Skill Validation failures already on main at 4074b2bf. This does not modify PR #130, the SELECT-004 public receipt, BEST, the reserve, thresholds, taxonomy, or the production head. Nothing was trained or scored.

Cause

Admission parity called train.main(["--offline", "--run", "--include-live"]) without a live store. The trainer fail-closes that case with return code 2 and JSON on stderr. The tests then parsed empty stdout.

test_no_hyperlex_or_abraxas_imports used a substring scan for from hyperlex, which also matches from hyperlexical....

Change

  • Launch the admission fixtures with ["--offline", "--run"] and parse stdout only when the trainer returns 0.
  • Keep a missing required live store fail-closed: return 2, JSON on stderr, no ADMISSION_PASS.
  • Scan imports by AST module root so hyperlexical is allowed and hyperlex / abraxas stay rejected.

Validation

Workflow command: HYPERLEX_OFFLINE=1 HYPERLEX_NO_RATE_LIMIT=1 PYTHONPATH=src python3 -m pytest -q

Baseline on 4074b2bf with full history: 15 failed, 1006 passed, 7 skipped.

After the change:

  • Python 3.10.21: focused 19 passed. Full 1015 passed, 13 skipped.
  • Python 3.11.16: focused 19 passed. Full 1015 passed, 13 skipped.
  • Python 3.12.3: focused 19 passed. Full 1023 passed, 7 skipped.

Do not merge this with PR #130.

The parity fixtures passed --include-live without a live store, then parsed empty stdout. Launch admission without that flag, and keep a missing required live store as return code 2 with JSON on stderr.

Scan imports with AST module roots so hyperlexical is not treated as hyperlex.
The parity fixtures passed --include-live without a live store, then parsed empty stdout. Launch admission without that flag, and keep a missing required live store as return code 2 with JSON on stderr.

Scan imports with AST module roots so hyperlexical is not treated as hyperlex.
The parity fixtures passed --include-live without a live store, then parsed empty stdout. Launch admission without that flag, and keep a missing required live store as return code 2 with JSON on stderr.

Scan imports with AST module roots so hyperlexical is not treated as hyperlex.
@scrimshawlife-ctrl
scrimshawlife-ctrl merged commit 69b456e into main Sep 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant