test: fix Skill Validation admission launch and import scan - #131
Merged
Merged
Conversation
The parity fixtures passed --include-live without a live store, then parsed empty stdout. Launch admission without that flag, and keep a missing required live store as return code 2 with JSON on stderr. Scan imports with AST module roots so hyperlexical is not treated as hyperlex.
The parity fixtures passed --include-live without a live store, then parsed empty stdout. Launch admission without that flag, and keep a missing required live store as return code 2 with JSON on stderr. Scan imports with AST module roots so hyperlexical is not treated as hyperlex.
The parity fixtures passed --include-live without a live store, then parsed empty stdout. Launch admission without that flag, and keep a missing required live store as return code 2 with JSON on stderr. Scan imports with AST module roots so hyperlexical is not treated as hyperlex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate CI fix for two Skill Validation failures already on
mainat4074b2bf. This does not modify PR #130, the SELECT-004 public receipt, BEST, the reserve, thresholds, taxonomy, or the production head. Nothing was trained or scored.Cause
Admission parity called
train.main(["--offline", "--run", "--include-live"])without a live store. The trainer fail-closes that case with return code 2 and JSON on stderr. The tests then parsed empty stdout.test_no_hyperlex_or_abraxas_importsused a substring scan forfrom hyperlex, which also matchesfrom hyperlexical....Change
["--offline", "--run"]and parse stdout only when the trainer returns 0.ADMISSION_PASS.hyperlexicalis allowed andhyperlex/abraxasstay rejected.Validation
Workflow command:
HYPERLEX_OFFLINE=1 HYPERLEX_NO_RATE_LIMIT=1 PYTHONPATH=src python3 -m pytest -qBaseline on
4074b2bfwith full history:15 failed, 1006 passed, 7 skipped.After the change:
19 passed. Full1015 passed, 13 skipped.19 passed. Full1015 passed, 13 skipped.19 passed. Full1023 passed, 7 skipped.Do not merge this with PR #130.