Repository navigation
fix: Android preflight hardening without a new application id - #12
Merged
Merged
Conversation
com.example.suas stays a labeled placeholder. The test activity is debug-only, backup is explicit, and logical retries reuse one idempotency key. SPEC-018 stays blocked.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5547768ead
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ServiceCard lived only in the debug harness, so release compilation of the launcher could not see it.
The product launcher, placeholder application id, memory-only session, and operation-scoped idempotency keys are now stated where later edits will see them.
Shelter preview requests one page and ignores next_cursor. Confirm and cancel keep their own keys. A 401 clears the memory bearer without minting a new key. Consent is a latest-read decision only; template copy stays not computable. Client routes are pinned to /api/v0.
A changed pickup, destination, or note mints new keys. SuasClient.create takes an explicit environment class, so a local base URL is accepted only with LOCAL. A missing dialer or messages app leaves the 911 and 988 instructions on screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Android client minted a new idempotency key on every submit call, shipped the template
allowBackup="true", exported theMainActivitytest harness, left release optimization off, and had no CI. The application id is still the scaffold value.Released authority
MOBILE_SURFACE.md§4.4, §5, §6, §8, §11ENVIRONMENT.md§2 and §5SAFETY_COPY.md§0 and §1.1ACCEPT_MEMORY_ONLY_DEFAULT0.6.0,RELEASE_MANIFEST-0.6.0.mdKEEP_BLOCKEDFiles changed
Explicit client pins, submission-scoped idempotency, crisis notice, debug-only
MainActivity, backup and network-security policy, release optimization, unit tests, forbidden-capability scan, CI, governance and accessibility notes.Tests
bash scripts/forbidden-capabilities.shpassed locally.Unit tests, lint, and
assembleReleasewere not run on this machine: no JDK and no Android SDK were installed. CI is the check for those tasks. This pull request does not claim emulator or device acceptance (DEVICE_ACCEPTANCE_REQUIRED).Security / privacy effect
Backup and device transfer exclude app data, and
allowBackupis false. Cleartext is limited to localhost, 127.0.0.1, and 10.0.2.2. The session stays in memory. The release artifact used by CI is signed with the builder's debug keystore, which is not a store credential.isDebuggableis false for release.Migration effect
None.
Rollback / forward-fix
Revert the commit.
applicationIdis unchanged, so installed debug builds keep the same package.Remaining unavailable surfaces
com.example.suasisPLACEHOLDER_NOT_RELEASED. Specs do not name a production application id. Do not invent one. No production host. No store upload. WCAG 2.2 AA is not claimed. Branch protection now requires a pull request, but it does not yet require thecontractcheck. Adding that check after it has run onmainisOPERATOR_ACTION_REQUIRED.