Skip to content

Label the product launcher Veteran's Passport, matching iOS - #17

Merged
scrimshawlife-ctrl merged 1 commit into
mainfrom
android-launcher-label
Oct 8, 2026
Merged

scrimshawlife-ctrl merged 1 commit into
mainfrom
android-launcher-label

Conversation

@scrimshawlife-ctrl

Copy link
Copy Markdown
Owner

Danny's yes (2026-10-07 5:15 PM PT, item A). Board question from the 4:41 PM batch: the product launcher read "MainActivity".

What changes

  • New string title_activity_root = Veteran\'s Passport, with the apostrophe escaped in strings.xml. RootActivity uses it as its label in the main manifest. This matches the iOS display name (INFOPLIST_KEY_CFBundleDisplayName = "Veteran's Passport").
  • app_name ("Suas") is unchanged. It is the application label (Settings > Apps). The launcher shows the activity label, so app_name is not the launcher label. The debug harness MainActivity keeps title_activity_main; it is not a launcher. The debug Demo and Local launcher labels are unchanged.
  • New LauncherLabelTest (2 local unit tests): RootActivity uses @string/title_activity_root, and that string resolves to "Veteran's Passport".
  • README and CONTEXT.md launcher tables now say "Veteran's Passport". CONTEXT.md links the Mac device handoff in SUAS-specs (docs/handoffs/MAC_DEVICE_WORK.md).
  • CHANGELOG [Unreleased] lines.

Local checks (CI cannot start: GitHub Actions billing block)

  • scripts/forbidden-capabilities.sh passed. scripts/openapi-client-pin.py against suas main docs/openapi/v0.json: client routes match.
  • ./gradlew :app:testDebugUnitTest :app:lintDebug :app:assembleDebug :app:assembleRelease :app:compileDebugAndroidTestKotlin: BUILD SUCCESSFUL, 47 unit tests, 0 failures.
  • aapt2 dump badging on the release APK: launchable-activity: name='com.example.suas.RootActivity' label='Veteran's Passport', application: label='Suas'. The debug APK also lists SUAS Demo (no server) and SUAS Local Worker.

Not checked here: what a real launcher shows on an emulator or device (no KVM). That is in the Mac handoff.

@scrimshawlife-ctrl
scrimshawlife-ctrl marked this pull request as ready for review October 8, 2026 00:18
@scrimshawlife-ctrl
scrimshawlife-ctrl merged commit 9fae299 into main Oct 8, 2026
1 check passed
@scrimshawlife-ctrl

Copy link
Copy Markdown
Owner Author

Merged at Danny's direction (2026-10-07 5:15 PM PT) while GitHub Actions jobs could not start because of the billing block.

Local checks: scripts/forbidden-capabilities.sh; scripts/openapi-client-pin.py against suas main OpenAPI; ./gradlew :app:testDebugUnitTest :app:lintDebug :app:assembleDebug :app:assembleRelease :app:compileDebugAndroidTestKotlin (47 unit tests, 0 failures); aapt2 dump badging on the release APK shows RootActivity labeled "Veteran's Passport".

Danny will verify with local runners.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T00:19:47.560010Z 7082ce6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant