Repository navigation
Label the product launcher Veteran's Passport, matching iOS - #17
Conversation
|
Merged at Danny's direction (2026-10-07 5:15 PM PT) while GitHub Actions jobs could not start because of the billing block. Local checks: Danny will verify with local runners. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Danny's yes (2026-10-07 5:15 PM PT, item A). Board question from the 4:41 PM batch: the product launcher read "MainActivity".
What changes
title_activity_root=Veteran\'s Passport, with the apostrophe escaped instrings.xml.RootActivityuses it as its label in the main manifest. This matches the iOS display name (INFOPLIST_KEY_CFBundleDisplayName = "Veteran's Passport").app_name("Suas") is unchanged. It is the application label (Settings > Apps). The launcher shows the activity label, soapp_nameis not the launcher label. The debug harnessMainActivitykeepstitle_activity_main; it is not a launcher. The debug Demo and Local launcher labels are unchanged.LauncherLabelTest(2 local unit tests):RootActivityuses@string/title_activity_root, and that string resolves to "Veteran's Passport".docs/handoffs/MAC_DEVICE_WORK.md).[Unreleased]lines.Local checks (CI cannot start: GitHub Actions billing block)
scripts/forbidden-capabilities.shpassed.scripts/openapi-client-pin.pyagainstsuasmaindocs/openapi/v0.json: client routes match../gradlew :app:testDebugUnitTest :app:lintDebug :app:assembleDebug :app:assembleRelease :app:compileDebugAndroidTestKotlin: BUILD SUCCESSFUL, 47 unit tests, 0 failures.aapt2 dump badgingon the release APK:launchable-activity: name='com.example.suas.RootActivity' label='Veteran's Passport',application: label='Suas'. The debug APK also listsSUAS Demo (no server)andSUAS Local Worker.Not checked here: what a real launcher shows on an emulator or device (no KVM). That is in the Mac handoff.