-
Notifications
You must be signed in to change notification settings - Fork 40
OMC: init heap/hint table across different shard #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hero78119
wants to merge
40
commits into
master
Choose a base branch
from
feat/shard_mem_init
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
need to figure out soundness #1178 |
Collaborator
Author
|
TODO
|
d047dde to
b610c86
Compare
b610c86 to
0c7475f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1145
Build on top of #1202
design rationale
Make init chip across shard, and assure consecutive address across shards without overlap. The mechanism to read from
previousshard works as usual.remove pitfall of
Platformclonewrap
Platform -> prog_datainto Arc otherwise each platform clone with a massive and hidden prover cost which we do not aware.benchmark
Run on
23817600with K=6, cache trace = none, 1x4090verifier sound TODOs in next PR
This PR got some verifier change, but not fully sound yet. A refactor is need to constrain specific chip number of instance is on the way, in short to support this
pi[<chip_id>].num_instance == chip_proof.num_instance. This is needed and assure init heap/hint in each shard are constrain within [platform.heap.start, platform.heap.end) or [platform.hint.start, platform.hint.end)pi[heap_length],pi[hint_length]equal to number of instance of respective init chip.pi[xxx_start_addr]+pi[xxx_length]within rangeAnother TODO for
Hintread andrkyzrkyzserialized data from hint_end -> hint_start, so right now hint still mostly happened in shard one because in first readmax_hint_addrgoes from end address. This make first shard still need to write bunch of records toshard ram circuit. To further improve this, we need to find way, e.g. make rykv go from lower address to high. So the first shard issue can be solved entirely