Skip to content

impl secp256r1_verify_signature #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hero78119 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

impl secp256r1_verify_signature #1210

hero78119 wants to merge 1 commit into from
+50 −6

Conversation

@hero78119
Copy link
Collaborator

@hero78119 hero78119 commented Dec 29, 2025 •
edited
Loading

Resolve emulator panic when proving few L1 blocks on ethproofs, which is some left-over.
Implement secp256r1_verify_signature by pure riscv and patch with precompile later

benchmark & verification

verified by proving with ethereum L1 block number 24030900 with e2e pass. Per secp256r1_verify_signature around 11.9M cycle

raw log

program executed 464286924 instructions in 1857147700 cycles

^[[1;34mDEBUG   ^[[0m    │  ┝━ 🐛 [debug]: PHANTOM_SYSCALL_LOG_PC_CYCLE: label=secp256r1_verify_signature start,pc=807e72c,cycle=1073390924
^[[1;34mDEBUG   ^[[0m    │  ┝━ 🐛 [debug]: PHANTOM_SYSCALL_LOG_PC_CYCLE: label=secp256r1_verify_signature end,pc=80822c8,cycle=1120958380

hero78119
hero78119 commented Dec 29, 2025
View reviewed changes
guest_libs/crypto/src/secp256r1.rs
#[inline]
pub fn secp256r1_verify_signature(_msg: &[u8; 32], _sig: &[u8; 64], _pk: &[u8; 64]) -> bool {
unimplemented!()
pub fn secp256r1_verify_signature(msg: &[u8; 32], sig: &[u8; 64], pk: &[u8; 64]) -> Option<()> {
Copy link
Collaborator Author

@hero78119 hero78119 Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer from https://github.com/scroll-tech/zkvm-prover/blob/2e8e29fd34d64728bfb71765bf100d5d947f9d3d/crates/types/chunk/src/crypto/secp256r1.rs#L6-L15

@hero78119 hero78119 force-pushed the feat/investigate_bug branch from 8d340bc to 86f6038 Compare December 29, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hero78119