Add gene annotations to anndata vars#23
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 93.69% 92.72% -0.98%
==========================================
Files 6 7 +1
Lines 333 371 +38
==========================================
+ Hits 312 344 +32
- Misses 21 27 +6
🚀 New features to boost your workflow:
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Outstanding issues:
|
Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
| def annotate_anndata( | ||
| adata_var: pd.DataFrame, | ||
| annotation_df: pd.DataFrame, | ||
| on: str = None, |
There was a problem hiding this comment.
I found the variable names a bit confusing because in pandas syntax on means that the column is present in both tables. Maybe we could name it left_on and right_on like in pd.merge
There was a problem hiding this comment.
I've changed to annotation_on and var_on to match the other params
|
Looks good! I added a few minor comments :) |
ivirshup
left a comment
There was a problem hiding this comment.
Yep, looks good.
One comment on the tutorial, can we make it so the AnnData used the same ensembl version as we annotate with? Either by using a different ensembl version, or a different AnnData.
|
@ivirshup wrt Ensembl version matching, the pbmc3k data was mapped with cellranger 1.1, but I am having a hard time matching this version to a Ensembl release. I'm gonna use the data from |
Closes #14