feat(ui): per-entry selection in the finished-review cleanup - #50
Merged
Conversation
The submit-review modal rendered one unscrollable Paragraph in a 72%x72% box, so a review batch taller than the modal was clipped with no scroll and no indicator — in the one surface whose job is confirming exactly what will be sent. The body now scrolls: Up/Down by a line, PageUp/PageDown by a real viewport, added to SUBMIT_FORGE_KEYS so the help overlay and footer stay in sync. Printable characters still fall through to the summary field, which is why the scroll keys are the arrow/page keys and not j/k. The offset is a Cell clamped to the content at render time (the help overlay's model) and reset on every fresh open, and when content is clipped the modal spends one row top and bottom on a marker naming how many lines are hidden in that direction. A blocked request-changes confirm jumps to the bottom so its hint can't land off-screen. Lines are pre-wrapped rather than handed to Paragraph's Wrap, so the count the scroll math clamps against is the row count the terminal really shows — otherwise a long batch's last rows stay unreachable and the hidden-line count understates. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWX3hBxudUxZooeph9ngEB
Replies in the submit-review modal previewed as `thread <id>: <body>` — a raw numeric id is meaningless at confirm time. Resolve each reply's target from the fetched thread overlay instead: root author and anchor (`path:line`, or `path (file-level)` once outdated), same conventions the thread overlay itself uses. Falls back to the id form only when the thread has dropped out of the overlay (e.g. a failed refresh). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWX3hBxudUxZooeph9ngEB
The submit modal's summary was a single-line push/pop field, so the substantive body of a forge review was capped at one line with no cursor motion or word-delete. `Ctrl-e` now hands it to the Compose editor, seeded with the text so far; saving returns to the modal with the whole body, cancelling leaves it as it was. The field shows the summary's first line plus a dim count of the lines it keeps off screen, and once the summary is multi-line the in-modal push/pop gestures step aside for `Ctrl-e` rather than silently mutate a line the reviewer can't see. Direct typing of a one-line summary is unchanged, as is Enter to confirm. Compose's two-mode `thread_id: Option<u64>` discriminant becomes a three-variant `ComposeKind`, so no combination of flags can describe a compose that is an annotation and a summary at once. The change is folded in here rather than split out because the third variant is the feature. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWX3hBxudUxZooeph9ngEB
A stopped submit left everything in one transient status line: honest about the counts, silent about which comments actually landed, so the only way to find out was to open the PR in a browser. The sequence now records what it set out to send (`SubmitAttempt`) into its report before it starts writing. Joined against the published and draft lists, that makes each item's fate knowable — published, pending draft, or never reached — rather than inferred from a diff of local state. A run that stops opens a read-only modal grouping every item under its outcome, named exactly as the submit preview named it (including the humanized "to <author> @ <path>:<line>" reply labels), with the review itself leading the not-sent group when the verdict never landed and the diagnostic underneath. The one-line status is unchanged and still set in both cases; a submit that publishes everything opens no modal. Keys come from a new SUBMIT_RESULT_KEYS table: Enter/Esc/q dismiss, U reopens the submit modal to retry the remainder, and j/k/arrows plus the page keys scroll (no summary field here, so the letter keys are free, unlike the submit modal). Long lists scroll with the render-time clamp the help overlay uses. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWX3hBxudUxZooeph9ngEB
Adds a cursor and per-entry checkbox to the finished-review cleanup modal (X on the Pull Requests tab): j/k/arrows move the highlight, Space toggles the highlighted entry (all checked by default), and confirm deletes only the selected subset. Zero-selected Enter is a no-op; deselected entries keep their unpublished-work warnings visible since the warning belongs to the entry, not to the deletion. New CleanupReviewsAction rows (MoveDown/MoveUp/Toggle) go through the shared CLEANUP_REVIEWS_KEYS table so the footer strip and ? help stay in sync automatically. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWX3hBxudUxZooeph9ngEB
Takes main's integrated side everywhere: 20 help sections, the unioned modes.rs imports, and the scrubbed section comments. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWX3hBxudUxZooeph9ngEB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth PR of the submit/modals chain (stacked on #49). The finished-review cleanup modal (
X) was all-or-nothing — no way to keep one review and delete the rest, despite per-entry unpublished-work warnings already being displayed.Changes
Spacetoggles the highlighted entry;j/k/arrows move a new clamped cursor (rendered viaListStatereverse-video highlight). Title readsN of M selected; confirm hint readsdelete selected (N)and dims at zero.Mode::CleanupReviews { cursor }(keepsMode: Copy, matching the launcher's pattern); the selection mask lives onAppbeside the entry snapshot. Keys added to the sharedCLEANUP_REVIEWS_KEYStable — footer and?help pick them up generically.Tests
9 added/updated: toggle + count, cursor walk + clamping, zero-selected no-op, default-all-checked render, deselected-keeps-warning render, drift test for the new table rows, and a real-git tempdir integration test proving a confirm with a deselected entry deletes exactly the selected subset and the deselected review's worktree/branch/state survive.
Tracking: ENG-177 (Linear). All four gates pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AWX3hBxudUxZooeph9ngEB