Skip to content

upd(checkin): add invalid credential response #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asd-a merged 1 commit into from
May 12, 2025
Merged

upd(checkin): add invalid credential response #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api
Open in desktop
Submodule api updated 1 files
+2 −0 api.rkt
20 changes: 14 additions & 6 deletions src/app/checkin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ impl CheckinAPI for AppState {
async fn checkin(&self, req: CheckinRequest, auth: Auth) -> CheckinResponse {
match self.signer.validate(api::Role::terminal, req.credential) {
api::Result::Ok(_) => {}
_ => panic!("Invalid credential"),
_ => {
return CheckinResponse::InvailidCredential;
}
}
let mut tx = self.database_pool.begin().await.unwrap();
let (status, begin_at, week): (Json<CheckinStatus>, String, String) = sqlx::query_as(
Expand Down Expand Up @@ -66,7 +68,9 @@ impl CheckinAPI for AppState {
async fn checkout(&self, req: CheckoutRequest, auth: Auth) -> CheckoutResponse {
match self.signer.validate(api::Role::terminal, req.credential) {
api::Result::Ok(_) => {}
_ => panic!("Invalid credential"),
_ => {
return CheckoutResponse::InvailidCredential;
}
}
let mut tx = self.database_pool.begin().await.unwrap();
let (status, end_at, week): (Json<CheckinStatus>, String, String) =
Expand Down Expand Up @@ -141,7 +145,6 @@ mod test {
}

#[sqlx::test(fixtures("users"))]
#[should_panic(expected = "Invalid credential")]
fn test_checkin_invalid_credential(pool: SqlitePool) {
let app = TestApp::new(pool);
let auth = match app
Expand All @@ -163,11 +166,13 @@ mod test {
signature: String::new(),
},
};
app.checkin(req, auth).await;
assert_eq!(
CheckinResponse::InvailidCredential,
app.checkin(req, auth).await
);
}

#[sqlx::test(fixtures("users"))]
#[should_panic(expected = "Invalid credential")]
fn test_checkout_invalid_credential(pool: SqlitePool) {
let app = TestApp::new(pool);
let auth = match app
Expand All @@ -189,7 +194,10 @@ mod test {
signature: String::new(),
},
};
app.checkout(req, auth).await;
assert_eq!(
CheckoutResponse::InvailidCredential,
app.checkout(req, auth).await
);
}

#[sqlx::test(fixtures("users", "spares"))]
Expand Down