feat(Admin): add spare set assignee#39
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new spare list management feature within the Admin page that allows setting the assignee for spare events. Key changes include:
- Updating date-fns imports to include a new formatting function and locale support.
- Adding the new SpareListManage component to display spare events in a table with assignment controls.
- Integrating an onChange handler on the assignee selection that updates via an API call.
Comments suppressed due to low confidence (1)
src/pages/Admin.tsx:411
- [nitpick] Consider using camelCase naming (e.g., spareEndTime) for utility functions to align with common JavaScript/TypeScript conventions.
format(spare_end_time(row.original), "H:mm", { locale: zhCN })
Early0v0
approved these changes
May 25, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.