Skip to content

Data serialization fix #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BHandle wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Data serialization fix #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94de36f
Added locking to prevent a data message and a keepalive ping from ins…
BHandle Jan 24, 2025
dfaf41a
Adjusted length algorithm to use Modulus
BHandle Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions IpcStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public class IpcStream : IDisposable

private bool _disposed = false;
protected bool encrypted = false;
private object _lockObject = new object();

/// <summary>
/// Constructor
Expand Down Expand Up @@ -119,16 +120,19 @@ protected async Task<byte[]> ReadBytesAsync()
/// <param name="buffer">byte buffer</param>
protected void WriteBytes(byte[] buffer)
{
int length = buffer.Length;
if (length > UInt16.MaxValue)
throw new InvalidOperationException("Message is too long");
lock (_lockObject)
{
int length = buffer.Length;
if (length > UInt16.MaxValue)
throw new InvalidOperationException("Message is too long");

// write message length
BaseStream.Write(new byte[] { (byte)(length / 256), (byte)(length & 255) }, 0, 2);
// write message length
BaseStream.Write(new byte[] {(byte) (length / 256), (byte) (length % 256)}, 0, 2);

// write message
BaseStream.Write(buffer, 0, length);
BaseStream.Flush();
// write message
BaseStream.Write(buffer, 0, length);
BaseStream.Flush();
}
}

/// <summary>
Expand Down