103. Binary Tree Zigzag Level Order Traversal#26
Open
seal-azarashi wants to merge 3 commits into
Open
Conversation
added 2 commits
September 21, 2024 00:25
liquo-rice
reviewed
Sep 20, 2024
| } | ||
|
|
||
| if (isReversed) { | ||
| valsInCurrentLevel = valsInCurrentLevel.isReversed(); |
Owner
Author
There was a problem hiding this comment.
いえ、ミスってますね...
すいません、ちゃんと確認せずにプルリクエストを出してしまっていました。修正しました。
fhiyo
reviewed
Sep 20, 2024
fhiyo
left a comment
fhiyo
left a comment
There was a problem hiding this comment.
良いと思います。zigzagLevelOrderValsの要素をArrayListにして、かつreversed()を使わないで書いてみてもいいかもしれません。
|
良いと思います |
oda
reviewed
Sep 30, 2024
|
|
||
| ### Step 1 を読みやすくする | ||
|
|
||
| オーバーヘッドを少しでも減らそうと工夫していましたが、それで削減できるのは微々たるものなので、読みやすさをとってレベルごとの処理の最後に reversed() メソッドを呼ぶように変えました。 |
There was a problem hiding this comment.
はい。思っているよりも、オーバーヘッドを改善した気になっていてもあんまり変わっていないことが多いです。
気になるようだったら、Profile を取ってみましょう。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/binary-tree-zigzag-level-order-traversal/description/