Skip to content

Correcting deprojection problems - #3

Open
j6626 wants to merge 1 commit into
seanandrews:mainfrom
SallyDJiang:deprojcorrection
Open

Correcting deprojection problems#3
j6626 wants to merge 1 commit into
seanandrews:mainfrom
SallyDJiang:deprojcorrection

Conversation

@j6626

@j6626 j6626 commented Aug 10, 2026

Copy link
Copy Markdown

The current version of the deprojection function fills in NaNs with

        r = np.where(np.isfinite(r_obs), r_obs, rf)
        t = np.where(np.isfinite(t_obs), t_obs, tf)
        z = np.where(np.isfinite(z_obs), z_obs, zf)

However, this creates a discontinuous grid at sufficiently high inclinations and leads to the addition of artificial disk components. I removed these lines and added np.nan_to_num calls around other functions that depend on r, t, and z. Since the current interpolation routine is leaving NaNs in the middle of the grid, I replaced it with SciPy's interpolation routine, which does not appear to exhibit the same issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant