Skip to content

Fix alerting sequence - #9

Merged
seanankenbruck merged 10 commits into
mainfrom
fix-alerting-sequence
Dec 9, 2025
Merged

seanankenbruck merged 10 commits into
mainfrom
fix-alerting-sequence

Conversation

@seanankenbruck

Copy link
Copy Markdown
Owner

This PR resolves a few bugs discovered during integration testing:

  • Notification channels are now properly registered in the DI Container for AlertingEngine
  • Created README.md in AlertingEngine project to show how to set notification channel secrets
  • Added JSON serialization fixes for case mismatch and converting condition operator to the proper AlertRule Comparison operator enum
  • Added logging throughout alert and notification flow
  • Fixed ShouldNotify logic to ensure this bool evaluates the conditions properly

@seanankenbruck
seanankenbruck merged commit 8e80643 into main Dec 9, 2025
1 check passed
@codecov

codecov Bot commented Dec 9, 2025

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant