-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add windows_named_pipe() option to client builder #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+320
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fdcc93 to
f647929
Compare
f647929 to
6c7e217
Compare
6c7e217 to
9d1e033
Compare
9d1e033 to
bae129f
Compare
|
Looks good to me. |
bae129f to
9b1e80d
Compare
9b1e80d to
272b6c9
Compare
|
I got an error in CI when I tried to use this. Is this correct? Is there a reason unix accepts a path-buf but windows doesn't? |
Owner
Author
|
Seems like an oversight. Windows named pipes want an |
272b6c9 to
c2eb0f2
Compare
|
Looks like this passes when we try to us it DataDog/libdatadog#1412. Thanks! |
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Dec 23, 2025
Bumps reqwest from 0.12.26 to 0.12.28. Release notes Sourced from reqwest's releases. v0.12.27 tl;dr Add ClientBuilder::windows_named_pipe(name) option that will force all requests over that Windows Named Pipe. What's Changed chore: Disable unused tokio-util codec feature by @tottoto in seanmonstar/reqwest#2893 chore: Use http_body_util::BodyDataStream by @tottoto in seanmonstar/reqwest#2892 feat: add windows_named_pipe() option to client builder by @seanmonstar in seanmonstar/reqwest#2789 Full Changelog: seanmonstar/reqwest@v0.12.26...v0.12.27 Changelog Sourced from reqwest's changelog. v0.12.28 Fix compiling on Windows if TLS and SOCKS features are not enabled. v0.12.27 Add ClientBuilder::windows_named_pipe(name) option that will force all requests over that Windows Named Piper. Commits d978599 v0.12.28 ef2768a fix: correctly import TokioIo on Windows (#2896) 1bf6441 v0.12.27 4967b1b feat: add windows_named_pipe() option to client builder (#2789) ef5b239 chore: Use http_body_util::BodyDataStream (#2892) a810004 chore: Disable unused tokio-util codec feature (#2893) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to adding support for Unix Domain Sockets in #2624, this adds support for Windows Named Pipes that functions the same way.
cc @danielsn @morrisonlevi