Add two-input stereo-output microphone mode#1
Open
seanogdelaney wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
add a Two-in/Stereo-out client audio mode
send the second input as an auxiliary mono Mic channel
use the Vocal instrument icon for the Mic channel
persist and expose the new audio-channel setting
Implements Two-in/Stereo-out: simplified support for separate mixer channels for a user's instrument and microphone jamulussoftware/jamulus#3756.
Implements a narrow subset of Multi Channel Fader on one Jamulus jamulussoftware/jamulus#96.
Related to Allow mono input device and channel selection for stereo input devices. jamulussoftware/jamulus#2344.
Validation:
Notes:
Running two jamulus clients can achieve this, but is a bit awkward.
This way makes it more accessible (less flexible, but easier).