fix parse_link for link-display-single-select when export excel - #901
Merged
Merged
Conversation
seafile-dev
reviewed
Aug 10, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Comment
Warnings:
- Missing regression coverage for the newly supported scalar dtable-db link values (see inline comment).
Suggested fix: add focusedparse_linktests covering both legacy dict values and scalar option IDs, including multiple linked records, and assert their exported display names.
| id2name = {op.get('id'): op.get('name') for op in options} | ||
| return ', '.join([select_option_to_name(id2name, cell) for cell in cell_data]) | ||
| return ', '.join([ | ||
| select_option_to_name(id2name, cell) if isinstance(cell, dict) |
There was a problem hiding this comment.
[Warning] 缺少混合数据形态回归测试
Why this matters:
本次修复依赖 dtable-db 返回的链接值既可能是旧的 dict，也可能是单选 option ID 字符串；该分支是此次 Excel 导出丢行问题的核心，但仓库中没有覆盖 parse_link 的测试。后续调整 option 映射或空值处理时，可能重新触发导出失败或输出错误标签而 CI 未发现。
Suggested fix: 为 parse_link 增加参数化测试：同时覆盖 dict 与字符串 option ID、多个链接记录，并断言均导出对应的 option name。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.