fix: add column identifier backticks and include test cases for inclu… - #905
Merged
Merged
Conversation
seafile-dev
reviewed
Aug 20, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Comment
Warnings:
- 新增用例只覆盖了
Creator和Modify，没有覆盖本任务所述的含-的创建者列名；因此无法防止反引号被移除后该实际场景回归。
Suggested fix: 将其中一个include_me用例的column_name改为如Creator-Name，并断言生成的 SQL 为`Creator-Name` = ...。
SailingBoat762
force-pushed
the
fix-filter
branch
from
August 21, 2026 08:47
d248dd2 to
e71d091
Compare
seafile-dev
approved these changes
Aug 21, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Approve
Blocking:
- 无。
Warnings:
- 无。此前指出的“连字符创建者列名未覆盖”已在当前提交中解决：新增用例通过
statistic2sql走完整的include_me路径，并断言生成`Creator-Name` = ...；实现也在CreatorOperator.op_include_me中对列标识符加了反引号。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…de_me filter predicate