Conversation
Run each scheduled automation rule inside its own try/except so that db/redis connection failures for one rule do not abort the whole scan. Materialize the rule query with fetchall() and close the query session before processing, and recreate the per-rule session on failure.
seafile-dev
reviewed
Sep 17, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Comment
Warnings:
- 缺少覆盖 Redis/数据库异常隔离行为的回归测试；已在行内说明。
Suggested fix: 为scan_rules注入可控的规则列表与依赖，模拟某条规则的配额查询抛出ConnectionError，断言后续规则仍会入队，并覆盖下一条规则使用新 session 的场景。
| try: | ||
| for rule in rules: | ||
| db_session = None | ||
| for rule in rules: |
There was a problem hiding this comment.
[Warning] 缺少故障隔离回归测试
Why this matters:
本次修改修复的是 Redis/数据库读取异常导致后续定时规则整体不执行的生产故障，但 PR 未新增覆盖该异常路径的测试。后续调整 session 生命周期或异常处理时，循环隔离与失败后重建 session 的关键行为可能再次退化而不被 CI 发现。
Suggested fix: 为 scan_rules 添加测试，模拟某条规则的 is_exceed 抛出连接异常，断言后续规则仍入队；同时验证下一次查询会使用新建的 session。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run each scheduled automation rule inside its own try/except so that db/redis connection failures for one rule do not abort the whole scan. Materialize the rule query with fetchall() and close the query session before processing, and recreate the per-rule session on failure.