add queryRows API for HTML pages - #20
Merged
Merged
Conversation
seafile-dev
requested changes
Aug 17, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Request changes
Blocking:
- 新增的
queryRows无法发布到 npm：包版本仍为已发布的 0.0.13；见行内评论。
Suggested fix: 升级并发布新的 SDK 版本，再更新配套生成页面使用的版本。
| return this.htmlPageAPI.listRows(this.options.pageId, tableName, start, limit, previewTableConfig); | ||
| } | ||
|
|
||
| queryRows({ tableId, filters, start, limit }) { |
There was a problem hiding this comment.
[Critical] 发布版本不会包含新 API
Why this matters:
package.json 仍是已发布的 0.0.13；npm 不允许覆盖同版本，所以本 PR 的 queryRows 无法通过正常发布进入 registry。配套生成页面加载已发布包后会调用不存在的 sdk.queryRows 并失败。
Suggested fix: 将 package.json 和 lockfile 升级到新的未发布版本（如 0.0.14）并先发布，再让 AI 模板引用该版本；补充从 npm 安装该版本后调用 queryRows 的发布验证。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.