Set prettier tabWidth to 4 to match the codebase - #8
Merged
Merged
Conversation
.prettierrc left tabWidth unset, so Prettier assumed its default of 2 while every file in the repo is indented with 4. Anyone formatting on save was reformatting whole files against the surrounding style, and `npm run format` reported 92 files purely because the config never described the code. This only aligns the config; nothing is reformatted. 81 files still differ on other rules (printWidth 100 against 384 lines that are longer, hand-formatted object literals), so `npm run format` stays red — but for real disagreements now rather than an indentation setting nobody chose. `npm run format` is not part of CI. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tn4FT2sVqoFz1QdpNDNAy7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.prettierrcsetztetabWidthnicht, Prettier nahm also seinen Default 2 — während das gesamte Repo mit 4 eingerückt ist.Zwei Folgen:
npm run formatmeldete 92 Dateien, ein großer Teil davon allein wegen dieser Einstellung.Dieser PR ändert nur die Config, es wird nichts umformatiert. Danach weichen noch 81 Dateien wegen anderer Regeln ab (
printWidth: 100bei 384 Zeilen, die länger sind; von Hand formatierte Object-Literals),npm run formatbleibt also rot — aber wegen echter Meinungsverschiedenheiten statt wegen einer Einrückung, die nie jemand so beschlossen hat.npm run formatist nicht Teil der CI (die macht lint, typecheck, test), es blockiert also nichts.Ein repo-weites Reformat habe ich bewusst nicht gemacht: 65–91 Dateien und ~9.800 bewegte Zeilen würden
git blameüber den kompletten OAuth- und Rate-Limit-Code entwerten und beide offenen PRs (#4, #5) zum Rebase zwingen. Falls gewünscht, gehört das in einen eigenen PR nach deren Merge, zusammen mit.git-blame-ignore-revs.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tn4FT2sVqoFz1QdpNDNAy7