Skip to content

fix(actions): keep expression syntax out of the napi-matrix description - #94

Merged
swernerx merged 1 commit into
mainfrom
fix/napi-matrix-description
Sep 16, 2026
Merged

swernerx merged 1 commit into
mainfrom
fix/napi-matrix-description

Conversation

@swernerx

Copy link
Copy Markdown
Member

The matrix output description of .github/actions/napi-matrix/action.yml quoted ${{ fromJSON(...) }} as usage text. GitHub's runner validates expression syntax anywhere in an action manifest, so a job using the action failed at Set up job before any step ran:

sebastian-software/standards/8a2f798…/.github/actions/napi-matrix/action.yml (Line: 26, Col: 18): Unexpected symbol: '...'. Located at position 10 within expression: fromJSON(...)

Seen on the first consumer: ferromark's publish.yml for v2.0.0-rc.2 (run) — release-please and publish-crates succeeded, napi-matrix failed, so the npm half of the release is pending a retry against a fixed pin. ferriki does not use this action, which is why it never surfaced.

The fix spells the usage out in words; no behavior change. A release of this fix is needed so consumers can pin it (standards-v0.12.1).

🤖 Generated with Claude Code

The `matrix` output's description quoted `${{ fromJSON(...) }}` as usage
text. The runner validates expression syntax anywhere in an action
manifest, so every workflow that referenced the action failed at job
setup with "Unexpected symbol: '...'" before a single step ran — seen on
the first consumer, ferromark's publish workflow for v2.0.0-rc.2. Spell
the usage out in words instead.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@swernerx
swernerx requested a review from a team as a code owner September 16, 2026 14:09
@recensor

recensor Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Reviewed ad7fd52 — approved.

@recensor recensor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE because the change removes the invalid placeholder expression without altering the action contract, and all repository checks pass.

Optional:

  • The pull request has no linked ticket.

@swernerx
swernerx merged commit e034ac3 into main Sep 16, 2026
6 checks passed
@swernerx
swernerx deleted the fix/napi-matrix-description branch September 16, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant