Add CLAUDE.md, align the Compiled CI pass with its documented command, and skip workflow runs on forks - #988
Merged
Conversation
lahma
changed the title
The Compiled pass command is spelled --property:Compiled=true: /p: works from PowerShell and the CI shells, but MSYS path conversion in Git Bash mangles it into a path-like argument that aborts the run with zero tests executed. Also refresh line references and the Shims.cs guard note that had drifted.
--property: and /p: are equivalent in the CI shells, but --property: matches the pack step's existing style, works from MSYS shells too, and keeps CI identical to the command AGENTS.md documents. Guard build, publish, and update-golden-liquid with the same repository check stale.yml already uses, so pushes and schedules on forks stop failing on missing secrets.
lahma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small maintenance fixes:
CLAUDE.md — adds the same stub parlot uses (https://github.com/sebastienros/parlot/blob/main/CLAUDE.md): Claude Code reads CLAUDE.md, so this imports the existing AGENTS.md to keep a single shared source of agent guidance.
AGENTS.md accuracy — the Compiled pass command is now spelled
dotnet test --property:Compiled=true./p:works from PowerShell and the CI shells, but MSYS path conversion in Git Bash (the shell coding agents get on Windows) rewrites/p:Compiled=truetop:Compiled=truebeforedotnet testsees it, and the mangled argument aborts the run with zero tests executed (exit code 5). A note in AGENTS.md documents the trap so agents don't rediscover it. Also refreshes a few line references that had drifted (NumberValue.cs, FluidOutputExtensions.cs, StringFilters.cs, Shims.cs guard note).CI — pr.yml and build.yml switch the Compiled step to
--property:Compiled=trueso CI runs exactly the documented command (both spellings are equivalent in CI;--property:matches the pack step's existing style). Verified locally that toggling the property forces a recompile withCOMPILEDdefined and all 2802 tests pass. build.yml, publish.yml, and update-golden-liquid.yml also get the sameif: github.repository == 'sebastienros/fluid'guard stale.yml already uses — today a fork's push to main fails at the MyGet publish step, and the Monday schedule fails on forks too.