Add extensible time zone resolution - #991
Merged
Merged
Conversation
Use TimeZoneInfo on modern targets, retain TimeZoneConverter for netstandard2.0, and document custom resolver configuration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2db8edf-4ed7-4f81-943f-65f98b07308d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern .NET can resolve IANA time zone IDs directly when ICU is available, so Fluid should not require TimeZoneConverter on those targets. Applications still need an escape hatch for Windows configurations without ICU and for custom compatibility requirements.
Changes
TemplateOptions.TimeZoneResolverand use it for explicittime_zonefilter identifiers.TimeZoneInfo.FindSystemTimeZoneByIdon modern targets while retaining TimeZoneConverter fornetstandard2.0.Validation
MiscFiltersTestswith both interpreted and compiled parser configurations.