Generate accessors for custom TemplateContext models - #992
Merged
Conversation
Infer concrete model types passed to TemplateContext with custom options and activate direct source-generated member accessors while preserving explicit registrations and reflection fallback semantics. Document NativeAOT and trimming compatibility boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3d315571-9fc7-4662-bd2d-5d739ff55308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Custom models passed to
TemplateContextcurrently rely on runtime member discovery unless applications explicitly register every model type. This leaves performance on the table and makes the NativeAOT/trimming boundary harder to understand.Approach
new TemplateContext(model, customOptions)and generate direct per-member accessors for eligible public fields and properties.TemplateOptions.Defaultremains unchanged.Performance
The targeted custom-model rendering benchmark improved from 145.0 ns to 138.3 ns (4.6%) with allocations unchanged at 608 B. The standard rendering benchmark remained effectively unchanged at 16.373 us versus 16.356 us.
Validation
Both interpreted and compiled grammar test passes succeed with 2,790 passing tests and 20 existing skips in each mode.