chore(deps): hold serial_test at 3.x - #149
Merged
Merged
Conversation
Dependabot opened a bump to serial_test 4.0.1, which fails CI outright:
error: rustc 1.88.0 is not supported by the following packages:
serial_test@4.0.1 requires rustc 1.93.1
serial_test_derive@4.0.1 requires rustc 1.93.1
This crate declares `rust-version = "1.88.0"`, and serial_test is a
dev-dependency used only inside `#[cfg(test)]` blocks. Taking the major
would raise the crate's MSRV by five minor versions — a cost every
consumer pays — to gain nothing at runtime.
Ignoring only `version-update:semver-major` for this one dependency, so
3.x patches and minors still flow. Reason recorded inline so the next
person does not re-open the same bump.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Sebastien Rousseau <sebastian.rousseau@gmail.com>
Assisted-by: Claude:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot opened #148 to bump
serial_testto 4.0.1. It fails CI outright:This crate declares
rust-version = "1.88.0", andserial_testis a dev-dependency used only inside#[cfg(test)]blocks (src/lib.rs,tests/test_lib.rs). Taking the major would raise the crate MSRV by five minor versions — a cost every consumer pays — to gain nothing at runtime.This ignores only
version-update:semver-majorfor that one dependency, so 3.x patches and minors keep flowing. The reason is recorded inline so the same bump is not re-opened later.#148 should be closed.
🤖 Generated with Claude Code