Add chatId to messages_fetch - #1
Closed
sebpretzer wants to merge 1 commit into
Closed
sebpretzer wants to merge 1 commit into
sebpretzer wants to merge 1 commit into
Conversation
sebpretzer
commented
Sep 27, 2026
sebpretzer
left a comment
sebpretzer
left a comment
Owner
Author
There was a problem hiding this comment.
do we need to add tests?
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The new parameter is correctly validated and applied using the existing typed chat predicate.
Review effort: Balanced
Findings: None
What changed in this PR
Adds conversation-specific filtering to messages_fetch.
Changes:
- Documents and accepts a
chatIdargument. - Applies the corresponding
MessagePredicate.chatIDfilter.
| File | Description |
|---|---|
App/Services/Messages.swift |
Adds parsing, schema documentation, and filtering for chatId. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
Author
|
Re: tests — not adding any, for these reasons:
Verified against a real
|
isPartOf reports each message's conversation @id, but nothing accepted it back. chatId maps to Madrid's chatID predicate and composes with the other filters, so chatId plus participants returns those senders' messages in that conversation. An unknown chatId matches nothing rather than falling back to every chat.
sebpretzer
force-pushed
the
messages-fetch-chat-id
branch
from
September 27, 2026 19:40
cc7d40a to
94ae8ba
Compare
Owner
Author
|
Moved to mattt#251 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.