Repository navigation
Extract date range parsing and conversation description in MessageService - #3
Draft
sebpretzer wants to merge 1 commit into
Draft
sebpretzer wants to merge 1 commit into
sebpretzer wants to merge 1 commit into
Conversation
…vice Move the start/end parsing out of the messages_fetch handler into a dateRange(from:) helper, and split the Conversation object built for isPartOf into conversation(for:) taking an already fetched Chat. No change in behavior: messages_fetch parses dates and describes conversations as before. Both helpers are reused by an upcoming chats_fetch tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for
chats_fetch(stacked PR on top of this one). No change in behavior.dateRange(from:): thestart/endparsing moves out of themessages_fetchhandler into a helper, unchanged, so another tool can parse dates the same way.conversation(for: Chat): theConversationobject built forisPartOfis split out ofconversation(for: Chat.ID, in:), so a tool that already has a fetchedChatcan describe it without fetching it again.isPartOfoutput is the same.Testing: builds clean in Debug.