Expose shouldStopAfterTurn on Agent - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shouldStopAfterTurncallback through publicAgentOptionsAgentand forward it intoAgentLoopConfigWhy
AgentLoopConfigalready supports stopping at a completed turn boundary, but callers of the publicAgentAPI cannot configure that hook. They currently have to subclassAgentand override the private_create_loop_configmethod.This keeps the public wrapper aligned with the loop API while preserving the existing ordering: the callback runs after tool execution and
prepareNextTurn, and before another provider turn.Testing
uvx ruff check packages/harn_agent/src/harn_agent/agent.py tests/test_agent/test_agent_api.pyuv run --all-packages pytest tests/test_agent -q— 83 passeduv build --package harn-agent