Repository navigation
Keep the capture difference warning for captures with ad breaks - #7
Merged
Merged
Conversation
The warning compared the file's container duration with its video track. On captures with ad breaks that difference only came from the embedded chapters running past the shortened video. Now that chapters use video offsets, and padded captures are as long as the stream, it no longer showed, so users weren't told that segments are missing. Count the recorded stream pauses in the same difference and show the captured content length (excluding black filler) as the video duration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XuPs3nkTaDwZGoCD8oKKEV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #6, the "capture difference" warning in the video info no longer appeared for new captures that had ad breaks. Users were no longer told that segments are missing from the capture.
Why it disappeared: the warning compares the file's container duration with its video track duration. On captures with ad breaks, that difference only existed because the embedded chapters ran past the end of the shortened video.
The fix reuses the existing
fileAndVideoDurationDifferencefunction and the existingduration-differencetranslation. No new functions or strings are added.Example, the capture with 8 ad breaks from #6:
Testing
twitch-vod-chat/dist-libbuild.VodItemVideoInfo.vue; its 4 existing indentation errors are unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01XuPs3nkTaDwZGoCD8oKKEV
Generated by Claude Code