Skip to content

Keep the capture difference warning for captures with ad breaks - #7

Merged
second2falcon merged 1 commit into
masterfrom
claude/intelligent-bardeen-nch87n
Oct 15, 2026
Merged

second2falcon merged 1 commit into
masterfrom
claude/intelligent-bardeen-nch87n

Conversation

@second2falcon

Copy link
Copy Markdown
Owner

Summary

Since #6, the "capture difference" warning in the video info no longer appeared for new captures that had ad breaks. Users were no longer told that segments are missing from the capture.

Why it disappeared: the warning compares the file's container duration with its video track duration. On captures with ad breaks, that difference only existed because the embedded chapters ran past the end of the shortened video.

The fix reuses the existing fileAndVideoDurationDifference function and the existing duration-difference translation. No new functions or strings are added.

  • The difference is now the larger of the file-duration difference and the total recorded stream pauses.
  • For padded captures, the "video duration" in the message is the captured content without the black filler, and the "full duration" is the file length.
  • Captures without stream pauses behave exactly as before.

Example, the capture with 8 ad breaks from #6:

Full duration is 04:38:18 while video duration is 04:26:04, a capture difference of 00:12:14 has been detected.

Testing

  • Client typecheck passes. The only error is the existing missing twitch-vod-chat/dist-lib build.
  • ESLint reports no new errors in VodItemVideoInfo.vue; its 4 existing indentation errors are unchanged.
  • Not checked in the running UI.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XuPs3nkTaDwZGoCD8oKKEV


Generated by Claude Code

The warning compared the file's container duration with its video track.
On captures with ad breaks that difference only came from the embedded
chapters running past the shortened video. Now that chapters use video
offsets, and padded captures are as long as the stream, it no longer
showed, so users weren't told that segments are missing.

Count the recorded stream pauses in the same difference and show the
captured content length (excluding black filler) as the video duration.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XuPs3nkTaDwZGoCD8oKKEV
@second2falcon
second2falcon merged commit 311abf3 into master Oct 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants