Skip to content

Type-fixes#5288

Merged
marchcat merged 6 commits intosecondlife:project/lua_editorfrom
tapple:type-fixes
Jan 19, 2026
Merged

Type-fixes#5288
marchcat merged 6 commits intosecondlife:project/lua_editorfrom
tapple:type-fixes

Conversation

@tapple
Copy link

@tapple tapple commented Jan 16, 2026

Part of a set of PR's improving the keywords files in lsl and slua:


These files are 99.9% auto-generated by secondlife/lsl-definitions#38 using these 2 commands:

python gen_definitions.py lsl_definitions.yaml syntax keywords_lsl_default.xml
python gen_definitions.py lsl_definitions.yaml slua_syntax slua_definitions.yaml keywords_lua_default.xml --pretty

The only difference is I manually re-added the XML comments that were already present


Yes, the tooltips look way worse in the xml file, but they look way better in-viewer. Also, they match the sim capability now:

Before After
image image

Yes, the tooltips look way worse in the xml file, but they look way better in-viewer
Copy link
Contributor

@marchcat marchcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marchcat
Copy link
Contributor

LGTM.
Is it ready for merge? (since the current status is "draft PR").

@tapple
Copy link
Author

tapple commented Jan 19, 2026

LGTM. Is it ready for merge? (since the current status is "draft PR").

This could be merged as-is. I'm still making a lot of changes, especially to keywords_lua. But, I could open another PR for the remaining changes, and it would be a smaller, easier-to-review diff then if they are a single PR. The remaining changes are smaller, more manual, less automated. Marking it as ready, and I'll push further changes to a new branch

Note that I added some commits after your approval but before I noticed it just now. I'd recommend you also merge at least the first one (apply lsl updates to lua keywords file), because:

  1. it's big
  2. it's just merging all the same changes from lsl_keywords_default.xml that you already approved into lua_keywords_default.xml

The 3 commits after that are a lot smaller and are similar to the changes I'm continuing to make

@tapple tapple marked this pull request as ready for review January 19, 2026 13:40
@marchcat
Copy link
Contributor

Created #5299 to track these changes; please link it to related new PRs or add it to commit messages.

@marchcat marchcat merged commit 7d61629 into secondlife:project/lua_editor Jan 19, 2026
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2026
@akleshchev akleshchev linked an issue Jan 20, 2026 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve keywords files for SLua and LSL

2 participants