Address review feedback: clarify documentation and fix type consistency - #306
Merged
da-niao-dan merged 3 commits intoDec 19, 2025
Merged
Conversation
Co-authored-by: da-niao-dan <9532472+da-niao-dan@users.noreply.github.com>
Co-authored-by: da-niao-dan <9532472+da-niao-dan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add more NNX and SL tutorials for MPLang v1
Address review feedback: clarify documentation and fix type consistency
Dec 19, 2025
da-niao-dan
marked this pull request as ready for review
December 19, 2025 02:33
da-niao-dan
merged commit Dec 19, 2025
ad3afbc
into
peicheng/nnx_split_learning_tutorial
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comments on tutorials 08 and 09 by correcting misleading documentation and fixing a type inconsistency bug.
Tutorial 08: Fix
nnx.eval_shapedocumentationnnx.eval_shapecreates abstract structures but parameters are materialized immediately byreplace_by_pure_dictTutorial 09: Multiple improvements
Removed non-existent pattern from documentation:
nnx.eval_shapefrom key concepts and takeaways - pattern not demonstrated in tutorial codeClarified reconstruction requirements:
Fixed type bug:
Improved function naming:
train_split_learning_for_n_steps→initialize_and_train_split_learning(performs both init and training)Enhanced dtype workaround documentation:
table_to_tensordtype constraint with alternative patterns for non-integer labels💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.