π‘οΈ Sentinel: [HIGH] Fix XSS vulnerabilities in magic link callback - #104
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerabilities in magic link callback#104secrooq wants to merge 1 commit into
Conversation
Co-authored-by: secrooq <81346684+secrooq@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Cross-Site Scripting (XSS). The
src/app/api/auth/magic/callback/route.tsAPI route returns a raw HTML string. Two XSS vectors were found:div.innerHTML.emailandtokenquery parameters were injected directly into an inline<script>block viaJSON.stringify()without escaping HTML tags, allowing an attacker to break out with</script>.π― Impact: If exploited, an attacker could craft a malicious magic link. When clicked by a victim, arbitrary JavaScript could execute in the context of the application, potentially leading to session hijacking or unauthorized actions.
π§ Fix:
div.innerHTMLwithdiv.textContentfor the client-side log rendering..replace(/</g, '\\u003c').replace(/>/g, '\\u003e')to theJSON.stringify()calls to properly encode HTML tags inside the JavaScript string context.β Verification: Verified by running
pnpm test,npx playwright test, andpnpm run build. All core tests pass and the application builds successfully.PR created automatically by Jules for task 13966788033555062294 started by @secrooq