π‘οΈ Sentinel: [CRITICAL] Fix hardcoded 2FA bypass backdoor - #109
π‘οΈ Sentinel: [CRITICAL] Fix hardcoded 2FA bypass backdoor#109secrooq wants to merge 1 commit into
Conversation
Co-authored-by: secrooq <81346684+secrooq@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: A hardcoded bypass secret (
"stealth_dev_bypass_root_2026") was used as a backdoor for 2FA verification insrc/auth.ts.π― Impact: This allowed potential unauthorized access if the secret was known.
π§ Fix: Updated the check to require the environment variable
ADMIN_BYPASS_SECRET. Default expected secret is nownulland it will only bypass 2FA if the environment variable is explicitly set and matches the entered code.β Verification: Ran unit tests and end-to-end playwright tests successfully.
PR created automatically by Jules for task 13236577053826937398 started by @secrooq