π‘οΈ Sentinel: [CRITICAL] Fix hardcoded secrets - #111
Conversation
Removed hardcoded fallback secrets for `AUTH_SECRET` and `ADMIN_BYPASS_SECRET` in `src/auth.ts` and `src/middleware.ts` to ensure the application fails securely if the required environment variables are not set. Co-authored-by: secrooq <81346684+secrooq@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Hardcoded fallback secrets for AUTH_SECRET and ADMIN_BYPASS_SECRET were found in
src/auth.tsandsrc/middleware.ts.π― Impact: If the environment variables were missing, the application would silently fallback to known keys ("stealth_dev_bypass_root_2026" and "stealth_relay_nextauth_secret_key_edge_v1_2026"), providing attackers with a known backdoor and decryption key.
π§ Fix: Removed the hardcoded fallbacks and updated the code to require the explicit environment variables or fail securely.
β Verification: Ran
pnpm test,pnpm run build, andnpx playwright testto ensure changes pass successfully.PR created automatically by Jules for task 3448338147996854965 started by @secrooq