fix: pass insecure_skip_tls to all Makefile test targets - #4
Open
kdacosta0 wants to merge 1 commit into
Open
Conversation
kdacosta0
force-pushed
the
fix/pass-insecure-skip-tls-to-test-targets
branch
from
July 14, 2026 09:58
612021a to
144055b
Compare
The k6-job.yml.j2 template already supports insecure_skip_tls for both the K6 container (K6_INSECURE_SKIP_TLS_VERIFY) and go-crypto-helper (INSECURE_SKIP_TLS_VERIFY), but no Makefile target was passing it through. This causes TLS failures on clusters with self-signed or internal CA certificates (e.g. OpenShift ingress for Keycloak OIDC). Add INSECURE_SKIP_TLS variable (defaults to false) and forward it to every sign-* and verify-* target. Document the option in README. Usage: INSECURE_SKIP_TLS=true make sign-fill Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kdacosta0
force-pushed
the
fix/pass-insecure-skip-tls-to-test-targets
branch
from
July 14, 2026 13:12
144055b to
5ceca28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
k6-job.yml.j2) already supportsinsecure_skip_tlsfor both the K6 container (K6_INSECURE_SKIP_TLS_VERIFY) and go-crypto-helper (INSECURE_SKIP_TLS_VERIFY), but no Makefile target was forwarding itx509: certificate signed by unknown authority) on clusters where the OpenShift ingress uses self-signed or internal CA certificates (e.g. Keycloak OIDC endpoint)INSECURE_SKIP_TLSvariable (defaults tofalse) and passes it to everysign-*andverify-*targetUsage
Test plan
make sign-smokestill works without the env var (TLS verification enabled by default)INSECURE_SKIP_TLS=true make sign-smokeresolves thex509: certificate signed by unknown authorityerror on clusters with self-signed certs🤖 Generated with Claude Code