fix: add cgwName_os candidate to FindBinary for inconsistent archives#89
Merged
Conversation
Some CLI archives use binary names without the arch suffix: gitsign_cli_linux, rekor_cli_linux, fetch_tsa_certs_linux Add cgwName_os as a candidate pattern. All 8 CLIs verified against actual CDN archives from 1.4.1. Implements SECURESIGN-2158 Signed-off-by: Sachin Sampras M <sampras343@gmail.com>
ompushkara
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
cgwName_os(e.g.,gitsign_cli_linux) as a candidate pattern inFindBinary. Some CLI archives from the Developer Portal contain binaries without the arch suffix.Binary naming in 1.4.1 archives
cosigncliNamerekor_cli_linuxcgwName_os(new)gitsign_cli_linuxcgwName_os(new)ec_linux_amd64cgwName_os_archfetch_tsa_certs_linuxcgwName_os(new)createtreecliNameupdatetreecliNametuftoolcliNameVerified
All 8 CLIs tested against actual CDN archives from 1.4.1 — 8/8 pass.
Implements SECURESIGN-2158