fix: simplify download fallback and fix resource leaks#90
Merged
Conversation
Simplify the openshift strategy to a two-tier fallback: 1. Current version from ConsoleCLIDownload CR (production) 2. Stable version (1.4.2) via CDN redirect resolution Remove all staging Developer Portal references and squid proxy configuration — preprod instances are not accessible outside the Red Hat VPN. Additional fixes from audit: - Fix goroutine/pipe reader leak on failed downloads (defer pr.Close) - Clean up temp directories on download failure (os.RemoveAll) - Add bare cgwName as FindBinary candidate for CLIs where cliName differs from cgwName (gitsign, rekor-cli) - Retry body-read errors during download instead of failing immediately Implements SECURESIGN-2158 Signed-off-by: Sachin Sampras M <sampras343@gmail.com>
Implements SECURESIGN-2158 Signed-off-by: Sachin Sampras M <sampras343@gmail.com>
JasonPowr
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the openshift strategy download fallback and fix several resource leaks found during audit.
Fallback chain (simplified)
developers.redhat.com/.../RHTAS/<current-version>/...developers.redhat.com/.../RHTAS/1.4.2/...redirect resolutionRemoved
developers.qa.redhat.com) — not accessible outside RH VPNproxyForStagingOnly,stagingProxySuffixes)Bug fixes
testSupport.go—defer pr.Close()openshift.go—os.RemoveAll(tmp)cgwNameasFindBinarycandidatecgw.go— handlesgitsign_cli,rekor_clitestSupport.go— explicitresp.Body.Close()Verified
go test ./pkg/...passImplements SECURESIGN-2158