Support running as python -m importlinter#217
Conversation
|
@QasimK as the original requester of this feature, would you mind taking a look and checking this meets your needs? |
seddonym
left a comment
seddonym
left a comment
There was a problem hiding this comment.
Thanks for looking at this!
I have to admit I am not that familiar with the reason for needing this feature, so I'm going to see if @QasimK has anything to add. But generally looks good apart from the exception in the .importlinter file.
I would feel more comfortable with this if there was a smoke test for this functionality. I'd like CI to fail if, say, the lint_imports_command function was renamed elsewhere without updating it here. Maybe something added to the tox.ini to run the tool in this way?
| domain | ||
| exhaustive = true No newline at end of file | ||
| exhaustive = true | ||
| exhaustive_ignores = |
There was a problem hiding this comment.
Rather than make an exception of this module, can we just list it as the top layer?
seddonym
left a comment
seddonym
left a comment
There was a problem hiding this comment.
Apologies, I meant to request changes 🤦🏻
| @@ -0,0 +1,5 @@ | |||
| # support running as `python -m importlinter` | |||
There was a problem hiding this comment.
Would be good to add a line in the docs about this.
| @@ -0,0 +1,5 @@ | |||
| # support running as `python -m importlinter` | |||
There was a problem hiding this comment.
Could we also have a line added to the CHANGELOG?
2 participants
Closes #195