Open
Conversation
Se deriva del codigo demo que ofrece google para java Por ahora solo envía videos que esten en un directorio especifico del filesystem
Una para la conexion con la api de youtube y otra para el manejo de la cli
…DSpace into ticket#8557-uploadVideos
…nto ticket#8557-uploadVideos
…nto ticket#8557-uploadVideos
arieljlira
requested changes
Nov 28, 2023
Member
arieljlira
left a comment
arieljlira
left a comment
There was a problem hiding this comment.
En general parece correcto. Agregué marcas para
- completar documentación de clases, métodos, ifs con condiciones complejas y poco claras.
- loguear info de error completa
Además me hace ruido la ubicación de los metadatos hardcodeados. En lo posible habría que externalizar a un método o subclase los hardocdes y dejar el código lo más templetizado que se pueda para que la lógica se entienda más fácilmente.
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
dspace/modules/additions/src/main/java/ar/edu/unlp/sedici/dspace/curation/VideoDeleteTask.java
Outdated
Show resolved
Hide resolved
dspace/modules/additions/src/main/java/ar/edu/unlp/sedici/dspace/curation/VideoUpdaterTask.java
Outdated
Show resolved
Hide resolved
...s/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderEventConsumer.java
Outdated
Show resolved
Hide resolved
...s/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderEventConsumer.java
Outdated
Show resolved
Hide resolved
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Show resolved
Hide resolved
arieljlira
requested changes
Dec 12, 2023
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
dspace/modules/additions/src/main/java/ar/edu/unlp/sedici/dspace/curation/VideoDeleteTask.java
Show resolved
Hide resolved
dspace/modules/additions/src/main/java/ar/edu/unlp/sedici/dspace/google/YoutubeAdapter.java
Outdated
Show resolved
Hide resolved
...s/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderEventConsumer.java
Outdated
Show resolved
Hide resolved
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
...les/additions/src/main/java/ar/edu/unlp/sedici/dspace/uploader/VideoUploaderServiceImpl.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Se añadió la funcionalidad de replicar los videos en SEDICI a Youtube. Esto se hizo mediante la implementación de las siguientes clases:
EventConsumer - VideoUploaderEventConsumer que escucha los eventos que se disparan sobre los items en SEDICI que tengan videos adjuntos y al detectarlos los encola en una queue de curation tasks.
Curation tasks - de acuerdo a los distintos tipos de eventos (update, modify, delete), que se ejecutan asincronicamente e invocan la clase Service
Service - VideoUploaderServiceImpl que envia los campos de metadatos necesarios (de acuerdo tambien al tipo de evento) al Adapter,
Adapter - YoutubeAdapter que se encarga de mapear los metadatos de SEDICI a los requeridos por youtube y de realizar la conexion y carga del video a la plataforma.