Skip to content

chore(ci): add nix flake check#176

Open
alexanderwiederin wants to merge 1 commit into
sedited:masterfrom
alexanderwiederin:nix-ci
Open

chore(ci): add nix flake check#176
alexanderwiederin wants to merge 1 commit into
sedited:masterfrom
alexanderwiederin:nix-ci

Conversation

@alexanderwiederin
Copy link
Copy Markdown
Collaborator

Summary

Adds a check to the CI to ensure the Nix flake works.

@alexanderwiederin alexanderwiederin added the no-changelog This PR does not require a CHANGELOG entry (e.g. docs, tests, CI changes). label May 7, 2026
@jaoleal
Copy link
Copy Markdown
Contributor

jaoleal commented May 7, 2026

This is nice, have you considered to add statix and nixfmt to checks too ? They can help to maintain the flake well writen. Heres an example on a recent change of mine.

https://github.com/getfloresta/Floresta/blob/22fa75a929f95d287806deed96f56619f36e7459/flake.nix#L28

@jaoleal
Copy link
Copy Markdown
Contributor

jaoleal commented May 8, 2026

Actually, I ask for statix and nixfmt to be added since this flake appears to be strangely formatted and my editor keeps reformating it all the time that I forgot to save without formatting... 😭

@alexanderwiederin
Copy link
Copy Markdown
Collaborator Author

Good call on nixfmt! I think it would be best if we merge this first and then edit the flake with the formatting changes - that way we are sure there are no functional changes.

Copy link
Copy Markdown
Contributor

@jaoleal jaoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 40e4db3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR does not require a CHANGELOG entry (e.g. docs, tests, CI changes).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants